Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A06117F59 for ; Fri, 11 Sep 2015 01:09:46 +0000 (UTC) Received: (qmail 16312 invoked by uid 500); 11 Sep 2015 01:09:46 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 16129 invoked by uid 500); 11 Sep 2015 01:09:46 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 15992 invoked by uid 99); 11 Sep 2015 01:09:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 01:09:46 +0000 Date: Fri, 11 Sep 2015 01:09:46 +0000 (UTC) From: "Jinfeng Ni (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-3754) Remove redundancy in run-time generated code for common column references. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739967#comment-14739967 ] Jinfeng Ni commented on DRILL-3754: ----------------------------------- Pull request : https://github.com/apache/drill/pull/153 > Remove redundancy in run-time generated code for common column references. > --------------------------------------------------------------------------- > > Key: DRILL-3754 > URL: https://issues.apache.org/jira/browse/DRILL-3754 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Codegen > Affects Versions: 1.1.0 > Reporter: Jinfeng Ni > Assignee: Jinfeng Ni > Fix For: 1.2.0 > > Attachments: 0002-DRILL-3754-Reduce-redundancy-in-run-time-generated-c.patch > > > When a operator (Filter, project) has expression which refer one same field multiple times, Drill will initialize a value vector and do value holder assignment for each field reference in the run-time generated code. The redundancy might impact the expression evaluation, after the compiled code is executed over large number of incoming rows. > This has been seen in recent performance issue reported on the drill user list, where the query contains multiple multiple in list filter conditions. > In this JIRA, we'll remove the redundancy for the common field reference, so that only one initialization and assignment happen in the run-time generated code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)