Return-Path: 
 <issues-return-23735-apmail-drill-issues-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-issues-archive@minotaur.apache.org
Delivered-To: apmail-drill-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A0C1A18D20
	for <apmail-drill-issues-archive@minotaur.apache.org>;
 Mon, 21 Sep 2015 17:11:07 +0000 (UTC)
Received: (qmail 79394 invoked by uid 500); 21 Sep 2015 17:11:04 -0000
Delivered-To: apmail-drill-issues-archive@drill.apache.org
Received: (qmail 79296 invoked by uid 500); 21 Sep 2015 17:11:04 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 79284 invoked by uid 99); 21 Sep 2015 17:11:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2015 17:11:04 +0000
Date: Mon, 21 Sep 2015 17:11:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12723506.1403650246000.29425.1442855464610@Atlassian.JIRA>
In-Reply-To: <JIRA.12723506.1403650246000@Atlassian.JIRA>
References: <JIRA.12723506.1403650246000@Atlassian.JIRA>
 <JIRA.12723506.1403650246273@arcas>
Subject: [jira] [Commented] (DRILL-1065) Provide a reset command to reset an
 option to its default value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901000#comment-14901000 ] 

ASF GitHub Bot commented on DRILL-1065:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r39996854
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java ---
    @@ -83,14 +84,30 @@ public OptionValue getOption(final String name) {
        */
       abstract boolean setLocalOption(OptionValue value);
     
    +  /**
    +   * Deletes the option with given name for this manager without falling back.
    +   *
    +   * @param type option type
    +   * @return true iff the option was successfully deleted
    --- End diff --
    
    this javadoc can have multiple meanings: _successfully deleted_ could either mean the implementation couldn't find the option, or it doesn't support the option type. It should actually return false if it doesn't support the option type


> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
>                 Key: DRILL-1065
>                 URL: https://issues.apache.org/jira/browse/DRILL-1065
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Aman Sinha
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very useful to have a 'reset' command to reset the value of an option to its default system value: 
>   ALTER SESSION RESET <option name> 
> If we don't want to add a new keyword for RESET, we could potentially overload the SET command and allow the user to set to the 'default' value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)