drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3845) Partition sender shouldn't send the "last batch" to a receiver that sent a "receiver finished" to the sender
Date Mon, 28 Sep 2015 17:03:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933574#comment-14933574
] 

ASF GitHub Bot commented on DRILL-3845:
---------------------------------------

GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/173

    DRILL-3845: Partition sender shouldn't send the "last batch" to a rec…

    …eiver that sent a "receiver finished" to the sender

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-3845

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit e10302c3a0ee27564e8651aa250a183858fcc761
Author: adeneche <adeneche@gmail.com>
Date:   2015-09-27T15:37:54Z

    DRILL-3845: Partition sender shouldn't send the "last batch" to a receiver that sent a
"receiver finished" to the sender

----


> Partition sender shouldn't send the "last batch" to a receiver that sent a "receiver
finished" to the sender
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-3845
>                 URL: https://issues.apache.org/jira/browse/DRILL-3845
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>
> Even if a receiver has finished and informed the corresponding partition sender, the
sender will still try to send a "last batch" to the receiver when it's done. In most cases
this is fine as those batches will be silently dropped by the receiving DataServer, but if
a receiver has finished +10 minutes ago, DataServer will throw an exception as it couldn't
find the corresponding FragmentManager (WorkEventBus has a 10 minutes recentlyFinished cache).
> DRILL-2274 is a reproduction for this case (after the corresponding fix is applied).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message