drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3811) AtomicRemainder incorrectly accounts for transferred allocations
Date Mon, 21 Sep 2015 20:56:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901384#comment-14901384
] 

ASF GitHub Bot commented on DRILL-3811:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/163#discussion_r40024717
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
---
    @@ -63,6 +63,29 @@
       private final static String planFile="/physical_allocator_test.json";
     
       @Test
    +  public void testTransfer() throws Exception {
    +    final Properties props = new Properties() {
    +      {
    +        put(ExecConstants.TOP_LEVEL_MAX_ALLOC, "1000000");
    +        put(ExecConstants.ERROR_ON_MEMORY_LEAK, "true");
    +      }
    +    };
    +    final DrillConfig config = DrillConfig.create(props);
    +    BufferAllocator a = new TopLevelAllocator(config);
    --- End diff --
    
    sure


> AtomicRemainder incorrectly accounts for transferred allocations
> ----------------------------------------------------------------
>
>                 Key: DRILL-3811
>                 URL: https://issues.apache.org/jira/browse/DRILL-3811
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>            Reporter: Deneche A. Hakim
>            Assignee: Chris Westin
>         Attachments: DRILL-3811.1.patch.txt
>
>
> when an allocator takes ownership of a buffer, AtomicRemainder.forceGet(int) is called
to account for the extra memory of the buffer, but when the allocator exceeds it's maximum
allocated memory it accounts for it incorrectly. In the following code, {{availableShared.andAndGet(size)}}
should actually receive {{-size}}:
> {code}
> public boolean forceGet(long size) {
>     if (get(size, this.applyFragmentLimit)) {
>       return true;
>     } else {
>       availableShared.addAndGet(size);
>       if (parent != null) {
>         parent.forceGet(size);
>       }
>       return false;
>     }
>   }
> {code}
> I was able to reproduce the issue in a simple unit test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message