drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3767) SchemaPath.getCompoundPath(String...strings) reverses it's input array
Date Sun, 13 Sep 2015 02:29:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742301#comment-14742301
] 

ASF GitHub Bot commented on DRILL-3767:
---------------------------------------

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/155#discussion_r39343781
  
    --- Diff: common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -220,9 +214,6 @@ public boolean contains(Object obj) {
         }
     
         SchemaPath other = (SchemaPath) obj;
    -    if (rootSegment == null) {
    --- End diff --
    
    Are you sure rootSegment is not null ? If so, pls add an assert otherwise the next statement
could potentially hit NPE. Also what about other.rootSegment ? Should that be checked ?


> SchemaPath.getCompoundPath(String...strings) reverses it's input array
> ----------------------------------------------------------------------
>
>                 Key: DRILL-3767
>                 URL: https://issues.apache.org/jira/browse/DRILL-3767
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Deneche A. Hakim
>            Assignee: Aman Sinha
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> If you pass an array of strings to {{SchemaPath.getCompoundPath()}}, the input array
will be reversed. This side effect is *undocumented* and has led to at least one known bug
DRILL-3758



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message