drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3535) Drop table support
Date Thu, 03 Sep 2015 02:14:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728396#comment-14728396
] 

ASF GitHub Bot commented on DRILL-3535:
---------------------------------------

Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38607640
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/BasicFormatMatcher.java
---
    @@ -72,7 +72,7 @@ public boolean supportDirectoryReads() {
     
       @Override
       public FormatSelection isReadable(DrillFileSystem fs, FileSelection selection) throws
IOException {
    -    if (isReadable(fs, selection.getFirstPath(fs))) {
    +    if (isFileReadable(fs, selection.getFirstPath(fs))) {
    --- End diff --
    
    You are right, ParquetFormatMatcher overrides isReadable to first check if the directory
contains the metadata file, if not it delegates to the base class method to check if a particular
file is readable or not. 
    
    The existing naming is a bit confusing. In BasicFormatMatcher there are two methods with
the same name:
    
    1. FormatSelection isReadable(DrillFileSystem fs, FileSelection selection) -> operates
on directory level
    2. boolean isReadable(DrillFileSystem fs, FileStatus status) -> operates on a single
file level.
    
    I've renamed the second to be called isFileReadable and exposed it in the abstract class
so drop can invoke it on every file. 
    
    



> Drop table support
> ------------------
>
>                 Key: DRILL-3535
>                 URL: https://issues.apache.org/jira/browse/DRILL-3535
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>
> Umbrella JIRA to track support for "Drop table" feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message