drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3535) Drop table support
Date Wed, 02 Sep 2015 15:34:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727514#comment-14727514
] 

ASF GitHub Bot commented on DRILL-3535:
---------------------------------------

Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38546769
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -104,6 +107,9 @@ public WorkspaceSchemaFactory(DrillConfig drillConfig, FileSystemPlugin
plugin,
           final FormatMatcher fallbackMatcher = new BasicFormatMatcher(formatPlugin,
               ImmutableList.of(Pattern.compile(".*")), ImmutableList.<MagicString>of());
           fileMatchers.add(fallbackMatcher);
    +      dropFileMatchers = fileMatchers.subList(0, fileMatchers.size() - 1);
    --- End diff --
    
    The matchers are the same except for the pattern associated with defaultInputFormat. Because
the pattern associated with defaultInputFormat is .* and we don't want to match and delete
on this.


> Drop table support
> ------------------
>
>                 Key: DRILL-3535
>                 URL: https://issues.apache.org/jira/browse/DRILL-3535
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>
> Umbrella JIRA to track support for "Drop table" feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message