drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3535) Drop table support
Date Tue, 01 Sep 2015 05:17:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724807#comment-14724807
] 

ASF GitHub Bot commented on DRILL-3535:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/140#discussion_r38386284
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
    @@ -321,8 +327,101 @@ public DrillTable create(String key) {
           return null;
         }
     
    +    private FormatMatcher findMatcher(FileStatus file) {
    +      FormatMatcher matcher = null;
    +      try {
    +        for (FormatMatcher m : dropFileMatchers) {
    +          if (m.isFileReadable(fs, file)) {
    +            return m;
    +          }
    +        }
    +      } catch (IOException e) {
    +        logger.debug("Failed to find format matcher for file: %s", file, e);
    +      }
    +      return matcher;
    +    }
    +
         @Override
         public void destroy(DrillTable value) {
         }
    +
    +    /**
    +     * Check if the table contains homogenenous files that can be read by Drill. Eg:
parquet, json csv etc.
    +     * However if it contains more than one of these formats or a totally different file
format that Drill cannot
    +     * understand then we will raise an exception.
    +     * @param key
    --- End diff --
    
    Key?


> Drop table support
> ------------------
>
>                 Key: DRILL-3535
>                 URL: https://issues.apache.org/jira/browse/DRILL-3535
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Mehant Baid
>            Assignee: Mehant Baid
>
> Umbrella JIRA to track support for "Drop table" feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message