drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3497) Throw UserException#validationError for errors when modifying options
Date Thu, 03 Sep 2015 20:26:46 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729718#comment-14729718
] 

ASF GitHub Bot commented on DRILL-3497:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/98#discussion_r38692395
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
    @@ -35,61 +42,65 @@ public FallbackOptionManager(OptionManager fallback) {
     
       @Override
       public Iterator<OptionValue> iterator() {
    -    return Iterables.concat(fallback, optionIterable()).iterator();
    +    return Iterables.concat(fallback, getLocalOptions()).iterator();
       }
     
       @Override
    -  public OptionValue getOption(String name) {
    -    final OptionValue opt = getLocalOption(name);
    -    if(opt == null && fallback != null){
    +  public OptionValue getOption(final String name) {
    +    final OptionValue value = getLocalOption(name);
    +    if (value == null && fallback != null) {
    --- End diff --
    
    Will add a precondition.


> Throw UserException#validationError for errors when modifying options
> ---------------------------------------------------------------------
>
>                 Key: DRILL-3497
>                 URL: https://issues.apache.org/jira/browse/DRILL-3497
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Sudheesh Katkam
>            Assignee: Jason Altekruse
>            Priority: Minor
>             Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message