drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3497) Throw UserException#validationError for errors when modifying options
Date Thu, 03 Sep 2015 15:44:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729288#comment-14729288
] 

ASF GitHub Bot commented on DRILL-3497:
---------------------------------------

Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/98#discussion_r38660966
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/ControlsInjectionUtil.java
---
    @@ -74,7 +75,7 @@ public static void setControls(final UserSession session, final String
controls)
     
         final OptionManager options = session.getOptions();
         try {
    -      options.getAdmin().validate(opValue);
    +      SystemOptionManager.getValidator(DRILLBIT_CONTROL_INJECTIONS).validate(opValue);
    --- End diff --
    
    This could just be a reference to the validator itself, as it is also public and static,
rather than looking it up by name.


> Throw UserException#validationError for errors when modifying options
> ---------------------------------------------------------------------
>
>                 Key: DRILL-3497
>                 URL: https://issues.apache.org/jira/browse/DRILL-3497
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Sudheesh Katkam
>            Assignee: Jason Altekruse
>            Priority: Minor
>             Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message