drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3122) Changing a session option to default value results in status as changed
Date Thu, 03 Sep 2015 22:39:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729935#comment-14729935
] 

ASF GitHub Bot commented on DRILL-3122:
---------------------------------------

Github user sudheeshkatkam closed the pull request at:

    https://github.com/apache/drill/pull/92


> Changing a session option to default value results in status as changed
> -----------------------------------------------------------------------
>
>                 Key: DRILL-3122
>                 URL: https://issues.apache.org/jira/browse/DRILL-3122
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.0.0
>            Reporter: Ramana Inukonda Nagaraj
>            Assignee: Sudheesh Katkam
>             Fix For: 1.2.0
>
>         Attachments: DRILL-3122.1.patch.txt
>
>
> Alter session option hash join to true(which is the default) and the following query
shows that the option has changed which could be misleading to users relying on the status
field to see if an option has changed or not. Especially in the case of a boolean value. 
> {code}
> 0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name like '%hash%';
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> |                    name                    |   kind   |  type   |  status  |   num_val
  | string_val  | bool_val  | float_val  |
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> | exec.max_hash_table_size                   | LONG     | SYSTEM  | DEFAULT  | 1073741824
 | null        | null      | null       |
> | exec.min_hash_table_size                   | LONG     | SYSTEM  | DEFAULT  | 65536
      | null        | null      | null       |
> | planner.enable_hash_single_key             | BOOLEAN  | SYSTEM  | DEFAULT  | null 
      | null        | true      | null       |
> | planner.enable_hashagg                     | BOOLEAN  | SYSTEM  | DEFAULT  | null 
      | null        | true      | null       |
> | planner.enable_hashjoin                    | BOOLEAN  | SYSTEM  | DEFAULT  | null 
      | null        | true      | null       |
> | planner.enable_hashjoin_swap               | BOOLEAN  | SYSTEM  | DEFAULT  | null 
      | null        | true      | null       |
> | planner.join.hash_join_swap_margin_factor  | DOUBLE   | SYSTEM  | DEFAULT  | null 
      | null        | null      | 10.0       |
> | planner.memory.hash_agg_table_factor       | DOUBLE   | SYSTEM  | DEFAULT  | null 
      | null        | null      | 1.1        |
> | planner.memory.hash_join_table_factor      | DOUBLE   | SYSTEM  | DEFAULT  | null 
      | null        | null      | 1.1        |
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> 9 rows selected (0.191 seconds)
> 0: jdbc:drill:zk=10.10.100.171:5181> alter session set `planner.enable_hashjoin`=true;
> +-------+-----------------------------------+
> |  ok   |              summary              |
> +-------+-----------------------------------+
> | true  | planner.enable_hashjoin updated.  |
> +-------+-----------------------------------+
> 1 row selected (0.083 seconds)
> 0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name like '%hash%';
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> |                    name                    |   kind   |   type   |  status  |   num_val
  | string_val  | bool_val  | float_val  |
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> | exec.max_hash_table_size                   | LONG     | SYSTEM   | DEFAULT  | 1073741824
 | null        | null      | null       |
> | exec.min_hash_table_size                   | LONG     | SYSTEM   | DEFAULT  | 65536
      | null        | null      | null       |
> | planner.enable_hash_single_key             | BOOLEAN  | SYSTEM   | DEFAULT  | null
       | null        | true      | null       |
> | planner.enable_hashagg                     | BOOLEAN  | SYSTEM   | DEFAULT  | null
       | null        | true      | null       |
> | planner.enable_hashjoin                    | BOOLEAN  | SYSTEM   | DEFAULT  | null
       | null        | true      | null       |
> | planner.enable_hashjoin                    | BOOLEAN  | SESSION  | CHANGED  | null
       | null        | true      | null       |
> | planner.enable_hashjoin_swap               | BOOLEAN  | SYSTEM   | DEFAULT  | null
       | null        | true      | null       |
> | planner.join.hash_join_swap_margin_factor  | DOUBLE   | SYSTEM   | DEFAULT  | null
       | null        | null      | 10.0       |
> | planner.memory.hash_agg_table_factor       | DOUBLE   | SYSTEM   | DEFAULT  | null
       | null        | null      | 1.1        |
> | planner.memory.hash_join_table_factor      | DOUBLE   | SYSTEM   | DEFAULT  | null
       | null        | null      | 1.1        |
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message