drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1942) Improve off-heap memory usage tracking
Date Fri, 11 Sep 2015 21:32:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741568#comment-14741568
] 

ASF GitHub Bot commented on DRILL-1942:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/133#discussion_r39319998
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java ---
    @@ -51,11 +48,12 @@ public BufferManager(BufferAllocator allocator, FragmentContext fragmentContext)
         this.fragmentContext = fragmentContext;
       }
     
    +  @Override
       public void close() throws Exception {
    -    Object[] mbuffers = ((LongObjectOpenHashMap<Object>)(Object)managedBuffers).values;
    -    for (int i =0; i < mbuffers.length; i++) {
    +    final Object[] mbuffers = ((LongObjectOpenHashMap<Object>) (Object) managedBuffers).values;
    +    for (int i = 0; i < mbuffers.length; i++) {
           if (managedBuffers.allocated[i]) {
    -        ((DrillBuf)mbuffers[i]).release();
    +        ((DrillBuf) mbuffers[i]).release(1);
    --- End diff --
    
    why not just call release(), it calls release(1) internally ?


> Improve off-heap memory usage tracking
> --------------------------------------
>
>                 Key: DRILL-1942
>                 URL: https://issues.apache.org/jira/browse/DRILL-1942
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>             Fix For: 1.2.0
>
>         Attachments: DRILL-1942.1.patch.txt, DRILL-1942.2.patch.txt, DRILL-1942.3.patch.txt
>
>
> We're using a lot more memory than we think we should. We may be leaking it, or not releasing
it as soon as we could. 
> This is a call to come up with some improved tracking so that we can get statistics out
about exactly where we're using it, and whether or not we can release it earlier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message