drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1065) Provide a reset command to reset an option to its default value
Date Fri, 25 Sep 2015 22:25:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908764#comment-14908764

ASF GitHub Bot commented on DRILL-1065:

Github user sudheeshkatkam commented on the pull request:

    Here's the list of keywords that we need to add to the non-reserved list: *["EXEC", "JOIN",
    Given Calcite's [note](https://github.com/apache/incubator-calcite/blob/master/core/src/main/codegen/templates/Parser.jj#L5114)
about such a list and the [standard](http://savage.net.au/SQL/sql-2003-2.bnf.html#xref-keywords),
I am against making this change. There are a lot of unit test failures (PARSE ERROR) in TestWindowFrame
and TestWindowFunctions with this change.
    @julianhyde What are the implications of adding a keyword to the non-reserved list (say
    Also the option *"store.parquet.block-size"* has a "-" in it which is not allowed. So
do we are escape the word? Or change the name?

> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>                 Key: DRILL-1065
>                 URL: https://issues.apache.org/jira/browse/DRILL-1065
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Aman Sinha
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.2.0
> Within a session, currently we set configuration options and it would be very useful
to have a 'reset' command to reset the value of an option to its default system value: 
>   ALTER SESSION RESET <option name> 
> If we don't want to add a new keyword for RESET, we could potentially overload the SET
command and allow the user to set to the 'default' value.

This message was sent by Atlassian JIRA

View raw message