drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1065) Provide a reset command to reset an option to its default value
Date Tue, 15 Sep 2015 23:27:46 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746489#comment-14746489
] 

ASF GitHub Bot commented on DRILL-1065:
---------------------------------------

GitHub user sudheeshkatkam opened a pull request:

    https://github.com/apache/drill/pull/159

    DRILL-1065: Support for ALTER ... RESET statement

    + Support for "SET option = value" statement (assumes scope as SESSION)
    + Better error messages in SetOptionHandler
    + Changes in CompoundIdentifierConverter
      - update when rewritten operand is not deeply equal to the original operand
      - Added Override annotations
    + Default ExecutionControls option value should be at SYSTEM level
    
    @jacques-n @vkorukanti please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-1065

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit f785c3ba4d50bfe5a7ff77a8d37b3589bbe1c1cf
Author: Sudheesh Katkam <skatkam@maprtech.com>
Date:   2015-09-15T23:13:23Z

    DRILL-1065: Support for ALTER ... RESET statement
    
    + Support for "SET option = value" statement (assumes scope as SESSION)
    + Better error messages in SetOptionHandler
    + Changes in CompoundIdentifierConverter
      - update when rewritten operand is not deeply equal to the original operand
      - Added Override annotations
    + Default ExecutionControls option value should be at SYSTEM level

----


> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
>                 Key: DRILL-1065
>                 URL: https://issues.apache.org/jira/browse/DRILL-1065
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Aman Sinha
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very useful
to have a 'reset' command to reset the value of an option to its default system value: 
>   ALTER SESSION RESET <option name> 
> If we don't want to add a new keyword for RESET, we could potentially overload the SET
command and allow the user to set to the 'default' value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message