drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1065) Provide a reset command to reset an option to its default value
Date Mon, 21 Sep 2015 15:29:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900825#comment-14900825
] 

ASF GitHub Bot commented on DRILL-1065:
---------------------------------------

Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r39984380
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
    @@ -107,7 +117,7 @@ public SqlNode visitChild(
           }
           SqlNode newOperand = operand.accept(CompoundIdentifierConverter.this);
           enableComplex = localEnableComplex;
    -      if (newOperand != operand) {
    +      if (! newOperand.equalsDeep(operand, false)) {
    --- End diff --
    
    Is it necessary to call equalsDeep()?  If the expression has an identifier which is rewritten
by CompoundIdentifierConverter, is it true that the new expression would be different in reference
from then original one?



> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
>                 Key: DRILL-1065
>                 URL: https://issues.apache.org/jira/browse/DRILL-1065
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Aman Sinha
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very useful
to have a 'reset' command to reset the value of an option to its default system value: 
>   ALTER SESSION RESET <option name> 
> If we don't want to add a new keyword for RESET, we could potentially overload the SET
command and allow the user to set to the 'default' value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message