Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3562C10E2C for ; Tue, 18 Aug 2015 18:55:47 +0000 (UTC) Received: (qmail 85533 invoked by uid 500); 18 Aug 2015 18:55:46 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 85338 invoked by uid 500); 18 Aug 2015 18:55:46 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 85143 invoked by uid 99); 18 Aug 2015 18:55:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2015 18:55:46 +0000 Date: Tue, 18 Aug 2015 18:55:46 +0000 (UTC) From: "Jinfeng Ni (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-3666) Replace assert uses in Drill's interpreter to catch error when it happens. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701783#comment-14701783 ] Jinfeng Ni commented on DRILL-3666: ----------------------------------- [~amansinha100], could you please review this small patch? Thanks! > Replace assert uses in Drill's interpreter to catch error when it happens. > --------------------------------------------------------------------------- > > Key: DRILL-3666 > URL: https://issues.apache.org/jira/browse/DRILL-3666 > Project: Apache Drill > Issue Type: Bug > Components: Query Planning & Optimization > Affects Versions: 1.1.0 > Reporter: Jinfeng Ni > Assignee: Jinfeng Ni > Attachments: 0001-DRILL-3666-Replace-assert-check-in-InterpreterEvalua.patch > > > Some code in interpreter uses assert to check certain conditions. However, if assertion enabled (-ea) is not turned on, such checking would skip. That might cause issues, since the caller may not know an error has happened in the interpreter, and will continue the execution. This has caused issue in partition pruning recently, when a bug in partition pruning passes an invalid expression to interpreter, yet the assert checking was skipped and end up with incorrect query result. > In stead, we should remove assert in interpreter, and make sure throw exception when certain conditions are not met. It's up the caller to decide what to do in the case of exception. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)