drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3707) Fix for DRILL-3616 can cause a NullPointerException in ExternalSort cleanup
Date Sat, 29 Aug 2015 16:52:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721154#comment-14721154
] 

Aman Sinha commented on DRILL-3707:
-----------------------------------

(as an aside, the PR does not show the comments history and resolution...is there a way to
retrieve it ?) 
1.  The comment about not storing null BatchGroup in the spilledBatchGroups list has been
addressed in your latest patch. 
2.  I am a little unsure about the following new change you made: 
      if (batchGroups.size() < 2) {
          return null;
      }
   For size 0 it makes sense.  For size = 1, is the justification that there is only 1 batch
group so there is no need to 
   merge ? But since this is returning null, what happens to that batch group ? 
   Can [~sphillips] also take a look at this change ?

> Fix for DRILL-3616 can cause a NullPointerException in ExternalSort cleanup
> ---------------------------------------------------------------------------
>
>                 Key: DRILL-3707
>                 URL: https://issues.apache.org/jira/browse/DRILL-3707
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>            Reporter: Deneche A. Hakim
>            Assignee: Aman Sinha
>             Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message