drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DRILL-3703) TopLevelAllocator has a public static mutable field set as a side effect of its Constructor
Date Mon, 24 Aug 2015 22:27:45 GMT

     [ https://issues.apache.org/jira/browse/DRILL-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Altekruse updated DRILL-3703:
-----------------------------------
    Assignee: Sudheesh Katkam  (was: Chris Westin)

> TopLevelAllocator has a public static mutable field set as a side effect of its Constructor
> -------------------------------------------------------------------------------------------
>
>                 Key: DRILL-3703
>                 URL: https://issues.apache.org/jira/browse/DRILL-3703
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Julien Le Dem
>            Assignee: Sudheesh Katkam
>
> https://github.com/apache/drill/blob/c5f1bbbb164351fc4b93ba2ef814ad7ab28a80e2/exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java#L44
> {noformat}   public static long MAXIMUM_DIRECT_MEMORY;{noformat}
> https://github.com/apache/drill/blob/c5f1bbbb164351fc4b93ba2ef814ad7ab28a80e2/exec/java-exec/src/main/java/org/apache/drill/exec/memory/TopLevelAllocator.java#L65
> {noformat}
> private TopLevelAllocator(DrillConfig config, long maximumAllocation, boolean errorOnLeak){
>     MAXIMUM_DIRECT_MEMORY = maximumAllocation;
> ...
> }
> {noformat}
> It seems to be used only in MemoryIterator (memory system table):
> https://github.com/apache/drill/blob/c5f1bbbb164351fc4b93ba2ef814ad7ab28a80e2/exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryIterator.java#L66
> Which should not need a static variable to access this information.
> https://github.com/apache/drill/search?utf8=%E2%9C%93&q=MAXIMUM_DIRECT_MEMORY



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message