drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3598) Use a factory to create the root allocator
Date Tue, 04 Aug 2015 18:31:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654103#comment-14654103
] 

ASF GitHub Bot commented on DRILL-3598:
---------------------------------------

GitHub user cwestin opened a pull request:

    https://github.com/apache/drill/pull/104

    DRILL-3598: use a factory to create the root allocator.

    - made the constructor for TopLevelAllocator package private to enforce this
    - other file cleanup in files the factory was added to
    
    Unit tests pass. Precommit suite passes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwestin/incubator-drill alloc-factory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 4d7021582bd31b5fc92c882af1fb467bd8e58ad1
Author: Chris Westin <cwestin@yahoo.com>
Date:   2015-08-04T13:26:57Z

    DRILL-3598: use a factory to create the root allocator.
    - made the constructor for TopLevelAllocator package private to enforce this

----


> Use a factory to create the root allocator
> ------------------------------------------
>
>                 Key: DRILL-3598
>                 URL: https://issues.apache.org/jira/browse/DRILL-3598
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>    Affects Versions: 1.1.0
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> Use a factory instead of the constructor for the top-level direct memory allocator so
that we can replace which allocator gets instantiated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message