drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3583) SUM on varchar column produces incorrect error
Date Thu, 20 Aug 2015 05:07:45 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704298#comment-14704298

ASF GitHub Bot commented on DRILL-3583:

GitHub user sudheeshkatkam opened a pull request:


    DRILL-3583: Added a deprecated UserException#build method to avoid fu…

    …ture mishaps
    @parthchandra please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudheeshkatkam/drill DRILL-3583

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
commit a03398b29f454e39593ad5da7cd7ae4898621e98
Author: Sudheesh Katkam <skatkam@maprtech.com>
Date:   2015-08-20T05:03:34Z

    DRILL-3583: Added a deprecated UserException#build method to avoid future mishaps


> SUM on varchar column produces incorrect error
> ----------------------------------------------
>                 Key: DRILL-3583
>                 URL: https://issues.apache.org/jira/browse/DRILL-3583
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>    Affects Versions: 1.1.0
>            Reporter: Adam Gilmore
>            Assignee: Parth Chandra
>             Fix For: 1.2.0
>         Attachments: DRILL-3583.1.patch.txt
> With the implementation of DRILL-3319, a bug was introduced whereby the codegen for an
aggregate when SUMing a varchar column fails:
> {code}
> 0: jdbc:drill:zk=local> select sum(full_name) from cp.`employee.json`;
> java.lang.RuntimeException: java.sql.SQLException: SYSTEM ERROR: CompileException: Line
57, Column 177: Unknown variable or type "logger"
> Fragment 0:0
> [Error Id: 8d5585c4-620c-4275-b0c5-8bc4cbc2da90 on pharma-lap14.ad.pharmadata.net.au:31010]
>         at sqlline.IncrementalRows.hasNext(IncrementalRows.java:73)
>         at sqlline.TableOutputFormat$ResizingRowsProvider.next(TableOutputFormat.java:87)
>         at sqlline.TableOutputFormat.print(TableOutputFormat.java:118)
>         at sqlline.SqlLine.print(SqlLine.java:1583)
>         at sqlline.Commands.execute(Commands.java:852)
>         at sqlline.Commands.sql(Commands.java:751)
>         at sqlline.SqlLine.dispatch(SqlLine.java:738)
>         at sqlline.SqlLine.begin(SqlLine.java:612)
>         at sqlline.SqlLine.start(SqlLine.java:366)
>         at sqlline.SqlLine.main(SqlLine.java:259)
> {code}
> This is due to the fact AggregateErrorFunctions now builds its errors with a "logger"
static field, which does not exist in the codegenned code.
> We either need to include a static logger in codegen aggregates, or revert back to simpler
exceptions for these functions.

This message was sent by Atlassian JIRA

View raw message