drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3496) Augment logging in DrillConfig and classpath scanning.
Date Mon, 03 Aug 2015 20:39:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652470#comment-14652470

Jason Altekruse commented on DRILL-3496:

Changes in DrillConfig:

     Collection<URL> urls = PathScanner.getConfigURLs();
     logger.debug("Loading configs at the following URLs {}", urls);
     for (URL url : urls) {
+      logger.debug("Loading module config. file at {}.", url);
       fallback = ConfigFactory.parseURL(url).withFallback(fallback);
-    Config effectiveConfig = ConfigFactory.load(overrideFileName).withFallback(fallback);
+    // 3. Load any overrides configuration file and overrides from JVM

[~sudheeshkatkam] - overrides from configuration file
[~dsbos] - 
That "overrides" is part of the noun phrase "overrides configuration file" (parallel to "defaults
configuration file" and "per-module configuration file") (not a reference to the overrides
from any such file).

Yes, it's a bit ambiguous between meaning that and seeming like a word is missing if one doesn't
see the other phrases. (Changing the "any" to "the" might reduce that ambiguity, but then
it would imply that that code expects there to be an overrides configuration file, when it's
actually optional.)
[~jaltekruse] - Maybe "Load any available overrides configuration files..."
[~dsbos] - Reworded a bit.

> Augment logging in DrillConfig and classpath scanning.
> ------------------------------------------------------
>                 Key: DRILL-3496
>                 URL: https://issues.apache.org/jira/browse/DRILL-3496
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Jason Altekruse

This message was sent by Atlassian JIRA

View raw message