Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20E1B18493 for ; Wed, 1 Jul 2015 23:42:06 +0000 (UTC) Received: (qmail 62223 invoked by uid 500); 1 Jul 2015 23:42:06 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 62152 invoked by uid 500); 1 Jul 2015 23:42:06 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 62040 invoked by uid 99); 1 Jul 2015 23:42:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 23:42:05 +0000 Date: Wed, 1 Jul 2015 23:42:05 +0000 (UTC) From: "Sudheesh Katkam (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-3167) When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611190#comment-14611190 ] Sudheesh Katkam commented on DRILL-3167: ---------------------------------------- Your patch file names are incorrect BTW. > When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client > --------------------------------------------------------------------------------------------------------------------------- > > Key: DRILL-3167 > URL: https://issues.apache.org/jira/browse/DRILL-3167 > Project: Apache Drill > Issue Type: Bug > Reporter: Deneche A. Hakim > Assignee: Deneche A. Hakim > Fix For: 1.2.0 > > Attachments: DRILL-3167.1.patch.txt, DRILL-3267.2.patch.txt, DRILL-3267.3.patch.txt, DRILL-3267.4.patch.txt > > > TestDrillbitResilience.foreman_runTryEnd() exposes this problem intermittently > The query fails and the Foreman reports the failure to the client which removes the results listener associated to the failed query. > Sometimes, a data batch reaches the client after the FAILED state already arrived, the client doesn't handle this properly and the corresponding buffer is never released. > Making the Foreman wait for all fragments to finish before sending the final state should help avoid such scenarios. -- This message was sent by Atlassian JIRA (v6.3.4#6332)