Return-Path: 
 <issues-return-21504-apmail-drill-issues-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-issues-archive@minotaur.apache.org
Delivered-To: apmail-drill-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0522D18229
	for <apmail-drill-issues-archive@minotaur.apache.org>;
 Mon, 27 Jul 2015 17:07:48 +0000 (UTC)
Received: (qmail 47719 invoked by uid 500); 27 Jul 2015 17:01:05 -0000
Delivered-To: apmail-drill-issues-archive@drill.apache.org
Received: (qmail 47639 invoked by uid 500); 27 Jul 2015 17:01:05 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 47486 invoked by uid 99); 27 Jul 2015 17:01:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 17:01:05 +0000
Date: Mon, 27 Jul 2015 17:01:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12822039.1429315935000.298697.1438016464985@Atlassian.JIRA>
In-Reply-To: <JIRA.12822039.1429315935000@Atlassian.JIRA>
References: <JIRA.12822039.1429315935000@Atlassian.JIRA>
 <JIRA.12822039.1429315935142@arcas>
Subject: [jira] [Commented] (DRILL-2818) Error message must be updated when
 query fails with FileNotFoundException
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DRILL-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643026#comment-14643026 ] 

ASF GitHub Bot commented on DRILL-2818:
---------------------------------------

Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35559349
  
    --- Diff: common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java ---
    @@ -27,11 +27,20 @@
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FormatPluginConfigBase.class);
     
     
    -  public synchronized static Class<?>[] getSubTypes(DrillConfig config){
    -    List<String> packages = config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    -    Class<?>[] sec = PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
    -    logger.debug("Adding Format Plugin Configs including {}", (Object) sec );
    -    return sec;
    +  public synchronized static Class<?>[] getSubTypes(DrillConfig config) {
    +    List<String> packages =
    +        config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    +    Class<?>[] pluginClasses =
    +        PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
    +    if (logger.isDebugEnabled()) {
    +      final StringBuilder sb = new StringBuilder();
    --- End diff --
    
    Reduce line count by factoring out part that Joiner could be used for.


> Error message must be updated when query fails with FileNotFoundException
> -------------------------------------------------------------------------
>
>                 Key: DRILL-2818
>                 URL: https://issues.apache.org/jira/browse/DRILL-2818
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: SQL Parser
>    Affects Versions: 0.9.0
>         Environment: exception branch
>            Reporter: Abhishek Girish
>            Assignee: Deneche A. Hakim
>            Priority: Minor
>              Labels: error_message_must_fix
>             Fix For: 1.3.0
>
>
> When user specifies a non-existent file/directory in a query, the following error is being thrown:
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: SYSTEM ERROR: Failure handling SQL.
> [9184097e-8339-42d3-96ce-1fba51c6bc78 on 192.168.158.107:31010]
> Error: exception while executing query: Failure while executing query. (state=,code=0)
> {code}
> This should be updated to 
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: File /tmp/tpch does not exist. 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)