drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3441) CompliantTextRecordReader#isStarQuery loops indefinitely
Date Wed, 08 Jul 2015 22:17:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619480#comment-14619480
] 

ASF GitHub Bot commented on DRILL-3441:
---------------------------------------

GitHub user hnfgns opened a pull request:

    https://github.com/apache/drill/pull/82

    DRILL-3441: fix indefinite loop problem in CompliantTextRecordReader#isStarQuery

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hnfgns/incubator-drill DRILL-3441

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit 51655617e048b0156058793d57505ac7ffb0267a
Author: Hanifi Gunes <hgunes@maprtech.com>
Date:   2015-07-08T20:18:43Z

    DRILL-3441: fix indefinite loop problem in CompliantTextRecordReader#isStarQuery

----


> CompliantTextRecordReader#isStarQuery loops indefinitely
> --------------------------------------------------------
>
>                 Key: DRILL-3441
>                 URL: https://issues.apache.org/jira/browse/DRILL-3441
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Text & CSV
>            Reporter: Hanifi Gunes
>            Assignee: Jason Altekruse
>             Fix For: 1.2.0
>
>
> The implementation recurse into itself and never terminates. We should fix this.
> {code}
>   @Override
>   public boolean isStarQuery() {
>     if(settings.isUseRepeatedVarChar()){
>       ...
>     }else{
>       return isStarQuery();
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message