drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3313) Eliminate redundant #load methods and unit-test loading & exporting of vectors
Date Wed, 29 Jul 2015 20:49:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646739#comment-14646739

ASF GitHub Bot commented on DRILL-3313:

Github user jaltekruse commented on the pull request:

    Apologies for the forthcoming double comments. I forgot to make comments on the pull request
and instead was viewing the individual commit. These comments are nicely aggregated on the
github IU, but are not currently picked up the the JIRA bot to copy the comments to the issue
report. I will be duplicating my comments on the same lines they were on the individual commit
on the pull request summary diff to make sure they get copied over.

> Eliminate redundant #load methods and unit-test loading & exporting of vectors
> ------------------------------------------------------------------------------
>                 Key: DRILL-3313
>                 URL: https://issues.apache.org/jira/browse/DRILL-3313
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Data Types
>    Affects Versions: 1.0.0
>            Reporter: Hanifi Gunes
>            Assignee: Jason Altekruse
>             Fix For: 1.2.0
> Vectors have multiple #load methods that are used to populate data from raw buffers.
It is relatively tough to reason, maintain and unit-test loading and exporting of data since
there is many redundant code around load methods. This issue proposes to have single #load
method conforming to VV#load(def, buffer) signature eliminating all other #load overrides.

This message was sent by Atlassian JIRA

View raw message