drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2818) Error message must be updated when query fails with FileNotFoundException
Date Mon, 20 Jul 2015 22:55:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634221#comment-14634221
] 

ASF GitHub Bot commented on DRILL-2818:
---------------------------------------

Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/93#discussion_r35053796
  
    --- Diff: common/src/main/java/org/apache/drill/common/logical/FormatPluginConfigBase.java
---
    @@ -27,11 +27,20 @@
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FormatPluginConfigBase.class);
     
     
    -  public synchronized static Class<?>[] getSubTypes(DrillConfig config){
    -    List<String> packages = config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    -    Class<?>[] sec = PathScanner.scanForImplementationsArr(FormatPluginConfig.class,
packages);
    -    logger.debug("Adding Format Plugin Configs including {}", (Object) sec );
    -    return sec;
    +  public synchronized static Class<?>[] getSubTypes(DrillConfig config) {
    +    List<String> packages =
    +        config.getStringList(CommonConstants.STORAGE_PLUGIN_CONFIG_SCAN_PACKAGES);
    +    Class<?>[] pluginClasses =
    +        PathScanner.scanForImplementationsArr(FormatPluginConfig.class, packages);
    +    if (logger.isDebugEnabled()) {
    +      final StringBuilder sb = new StringBuilder();
    --- End diff --
    
    Yeah, I thought it should be factored out, but it wasn't clear where.   (Also, the functionality
is close to that of some utility join(...) methods--but not quite the same.)
    



> Error message must be updated when query fails with FileNotFoundException
> -------------------------------------------------------------------------
>
>                 Key: DRILL-2818
>                 URL: https://issues.apache.org/jira/browse/DRILL-2818
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: SQL Parser
>    Affects Versions: 0.9.0
>         Environment: exception branch
>            Reporter: Abhishek Girish
>            Assignee: Deneche A. Hakim
>            Priority: Minor
>              Labels: error_message_must_fix
>             Fix For: 1.3.0
>
>
> When user specifies a non-existent file/directory in a query, the following error is
being thrown:
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: SYSTEM ERROR: Failure handling SQL.
> [9184097e-8339-42d3-96ce-1fba51c6bc78 on 192.168.158.107:31010]
> Error: exception while executing query: Failure while executing query. (state=,code=0)
> {code}
> This should be updated to 
> {code:sql}
> > show files from dfs.tmp.`tpch`;
> Query failed: File /tmp/tpch does not exist. 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message