drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venki Korukanti (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2403) TimePrintMillis.toString() misses leading zeros in post-decimal-point part
Date Thu, 11 Jun 2015 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582694#comment-14582694
] 

Venki Korukanti commented on DRILL-2403:
----------------------------------------

Looks good, +1. Please add unittests.

> TimePrintMillis.toString() misses leading zeros in post-decimal-point part
> --------------------------------------------------------------------------
>
>                 Key: DRILL-2403
>                 URL: https://issues.apache.org/jira/browse/DRILL-2403
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Mehant Baid
>             Fix For: 1.1.0
>
>         Attachments: DRILL-2403.patch
>
>
> In org.apache.drill.exec.vector.accessor.sql.TimePrintMillis, the toString() method includes
this code:
>     baseTime = baseTime + "." + Integer.toString(millis);
> (Consider the result when millis is in the range 1 to 99.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message