drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike de Rhino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1591) Drill Web UI Page Source Has Links To External Sites
Date Fri, 26 Jun 2015 13:22:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602860#comment-14602860

Mike de Rhino  commented on DRILL-1591:

@Jacqques Nadeau

This ticket shouldn't have been closed. There's still plenty of CDN references in the code:


introduced changes that are still present on:


<#macro page_head>
  <link rel="stylesheet" type="text/css" href="//code.jquery.com/ui/1.10.3/themes/smoothness/jquery-ui.css">
  <link rel="stylesheet" type="text/css" href="//cdn.datatables.net/plug-ins/be7019ee387/integration/jqueryui/dataTables.jqueryui.css">

  <script type="text/javascript" language="javascript" src="//code.jquery.com/jquery-1.10.2.min.js"></script>
  <script type="text/javascript" language="javascript" src="//cdn.datatables.net/1.10.0/js/jquery.dataTables.js"></script>

  <link rel="stylesheet" type="text/css" href="//cdn.datatables.net/colvis/1.1.0/css/dataTables.colVis.css">
  <script type="text/javascript" language="javascript" src="//cdn.datatables.net/colvis/1.1.0/js/dataTables.colVis.min.js"></script>

> Drill Web UI Page Source Has Links To External Sites
> ----------------------------------------------------
>                 Key: DRILL-1591
>                 URL: https://issues.apache.org/jira/browse/DRILL-1591
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>    Affects Versions: 0.6.0
>            Reporter: MUFEED USMAN
>            Assignee: Jacques Nadeau
>            Priority: Minor
>             Fix For: 0.7.0
> The Drill web UI page source has links to external sites that can break the functionality
on clusters that do not have access to the internet.
> <link href="http://netdna.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css"
> <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> <script src="http://netdna.bootstrapcdn.com/bootstrap/3.1.1/js/bootstrap.min.js"></script>
> An advisable thing would be to put the .js and .css files on the web server itself and
not link them to external servers.

This message was sent by Atlassian JIRA

View raw message