Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Mon, 4 May 2015 21:45:05 +0000 (UTC)
From: "Daniel Barclay (Drill) (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12826488.1430446301000.74906.1430775905919@Atlassian.JIRA>
In-Reply-To: <JIRA.12826488.1430446301000@Atlassian.JIRA>
References: <JIRA.12826488.1430446301000@Atlassian.JIRA>
 <JIRA.12826488.1430446301636@arcas>
Subject: [jira] [Updated] (DRILL-2932) Error text reported via
 System.out.println rather than thrown SQLException's message
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DRILL-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Barclay (Drill) updated DRILL-2932:
------------------------------------------
    Attachment: DRILL-2932.2.patch.txt

> Error text reported via System.out.println rather than thrown SQLException's message
> ------------------------------------------------------------------------------------
>
>                 Key: DRILL-2932
>                 URL: https://issues.apache.org/jira/browse/DRILL-2932
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Daniel Barclay (Drill)
>            Priority: Critical
>         Attachments: DRILL-2932.2.patch.txt
>
>
> There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...):
>   System.out.println("Query failed: " + ex.getMessage());
> (That submissionFailed(...) is part of the implementation of Statement.execute...(...) methods and ResultSet.)
> In SQLLine, this causes the exception message, which currently doesn't show up otherwise in SQLLine, to show up when running SQLLine interactively.
> However, writing that to System.out. is completely inappropriate. 
> JDBC specifies that implementations throw SQLExceptions to report errors\--implementations should not be unilaterally be deciding to write to stdout\--or stderr.
> &nbsp;
> Additionally, the text intended to reach the user is not copied into the message of the SQLException that is thrown to the JDBC client.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)