Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B770183F8 for ; Sat, 2 May 2015 04:22:09 +0000 (UTC) Received: (qmail 21097 invoked by uid 500); 2 May 2015 04:22:09 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 20848 invoked by uid 500); 2 May 2015 04:22:09 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 20769 invoked by uid 99); 2 May 2015 04:22:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 May 2015 04:22:09 +0000 Date: Sat, 2 May 2015 04:22:09 +0000 (UTC) From: "Daniel Barclay (Drill) (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-2932) Errors reported through System.out.println, and text not in thrown SQLException message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524563#comment-14524563 ] Daniel Barclay (Drill) commented on DRILL-2932: ----------------------------------------------- Additionally, the text intended to reach the user is not copied into the message of the SQLException that is thrown to the JDBC client. > Errors reported through System.out.println, and text not in thrown SQLException message > --------------------------------------------------------------------------------------- > > Key: DRILL-2932 > URL: https://issues.apache.org/jira/browse/DRILL-2932 > Project: Apache Drill > Issue Type: Bug > Components: Client - JDBC > Reporter: Daniel Barclay (Drill) > Assignee: Daniel Barclay (Drill) > Priority: Critical > > There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...): > System.out.println("Query failed: " + ex.getMessage()); > (That submissionFailed(...) is part of the implementation of Statement.execute...(...) methods and ResultSet.) > In SQLLine, this causes the exception message, which currently doesn't show up otherwise in SQLLine, to show up when running SQLLine interactively. > However, writing that to System.out. is completely inappropriate. > JDBC specifies that implementations throw SQLExceptions to report errors\--implementations should not be unilaterally be deciding to write to stdout\--or stderr. -- This message was sent by Atlassian JIRA (v6.3.4#6332)