Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED46F17999 for ; Fri, 22 May 2015 16:53:19 +0000 (UTC) Received: (qmail 84907 invoked by uid 500); 22 May 2015 16:53:19 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 84878 invoked by uid 500); 22 May 2015 16:53:19 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 84868 invoked by uid 99); 22 May 2015 16:53:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 May 2015 16:53:19 +0000 Date: Fri, 22 May 2015 16:53:19 +0000 (UTC) From: "Chris Westin (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DRILL-2923) Ensure all unit tests pass without assertions enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Westin updated DRILL-2923: -------------------------------- Attachment: DRILL-2923.1.patch.txt I went ahead and did this, because I already had the changes in another branch for DRILL-1942, and this will help to break that patch up into smaller chunks that are easier to review. https://reviews.apache.org/r/34598/ > Ensure all unit tests pass without assertions enabled > ----------------------------------------------------- > > Key: DRILL-2923 > URL: https://issues.apache.org/jira/browse/DRILL-2923 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Reporter: Chris Westin > Assignee: Chris Westin > Fix For: 1.2.0 > > Attachments: DRILL-2923.1.patch.txt > > > I recently discovered that the test TestValueVector.java only passes if assertions are enabled (-ea to the JVM). This means that there are conditions which will fail in the wild, because production users don't run with assertions enabled. Someone needs to do a test run of mvn install with the -ea removed from the surefire command line and make sure that everything passes, and if not, we should fix them. We should also find a way to do this periodically, as part of CI, or as part of our regular test suites. -- This message was sent by Atlassian JIRA (v6.3.4#6332)