drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hanifi Gunes (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DRILL-2996) ValueVectors shouldn't call reAlloc() in a while() loop
Date Fri, 29 May 2015 20:05:17 GMT

     [ https://issues.apache.org/jira/browse/DRILL-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hanifi Gunes updated DRILL-2996:
--------------------------------
    Priority: Minor  (was: Major)

> ValueVectors shouldn't call reAlloc() in a while() loop
> -------------------------------------------------------
>
>                 Key: DRILL-2996
>                 URL: https://issues.apache.org/jira/browse/DRILL-2996
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Data Types
>    Affects Versions: 0.9.0
>            Reporter: Chris Westin
>            Assignee: Hanifi Gunes
>            Priority: Minor
>
> Instead, reAlloc() should be change to take a "new minimum size" as an argument. This
value is just the value used to determine the while loops' termination. Then reAlloc() can
figure out how much more to allocate once and for all, instead of possibly reallocating and
copying more than once, and it can make sure that the size doesn't overflow (we've seen some
instances of the allocator being called with negative sizes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message