drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay (Drill) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DRILL-2932) Hard-coded System.out.println( "Query failed ...") in DrillResultSetImpl.
Date Fri, 01 May 2015 02:26:06 GMT

     [ https://issues.apache.org/jira/browse/DRILL-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Barclay (Drill) updated DRILL-2932:
------------------------------------------
    Description: 
There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...):

  System.out.println("Query failed: " + ex.getMessage());

(That submissionFailed(...) is part of the implementation of Statement.execute...(...) methods
and ResultSet.)


In SQLLine, this causes the exception message, which currently doesn't show up otherwise in
SQLLine, to show up when running SQLLine interactively.

However, writing that to System.out. is completely inappropriate. 

JDBC specifies that implementations throw SQLExceptions to report errors\--implementations
should not be unilaterally be deciding to write to stdout\--or stderr.




  was:
There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...):

  System.out.println("Query failed: " + ex.getMessage());

(That submissionFailed(...) is part of the implementation of Statement.execute...(...) methods
and ResultSet.)


In SQLLine, this causes the exception message, which currently doesn't show up otherwise in
SQLLine, to show up when running SQLLine interactively.

However, writing that to System.out. is completely inappropriate. 

JDBC specifies that implementations throw SQLExceptions to report errors--implementations
should not be unilaterally be deciding to write to stdout--or stderr.





> Hard-coded System.out.println( "Query failed ...") in DrillResultSetImpl.
> -------------------------------------------------------------------------
>
>                 Key: DRILL-2932
>                 URL: https://issues.apache.org/jira/browse/DRILL-2932
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Daniel Barclay (Drill)
>
> There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...):
>   System.out.println("Query failed: " + ex.getMessage());
> (That submissionFailed(...) is part of the implementation of Statement.execute...(...)
methods and ResultSet.)
> In SQLLine, this causes the exception message, which currently doesn't show up otherwise
in SQLLine, to show up when running SQLLine interactively.
> However, writing that to System.out. is completely inappropriate. 
> JDBC specifies that implementations throw SQLExceptions to report errors\--implementations
should not be unilaterally be deciding to write to stdout\--or stderr.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message