drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DRILL-2923) Ensure all unit tests pass without assertions enabled
Date Fri, 22 May 2015 16:53:19 GMT

     [ https://issues.apache.org/jira/browse/DRILL-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Westin updated DRILL-2923:
--------------------------------
    Attachment: DRILL-2923.1.patch.txt

I went ahead and did this, because I already had the changes in another branch for DRILL-1942,
and this will help to break that patch up into smaller chunks that are easier to review.

https://reviews.apache.org/r/34598/

> Ensure all unit tests pass without assertions enabled
> -----------------------------------------------------
>
>                 Key: DRILL-2923
>                 URL: https://issues.apache.org/jira/browse/DRILL-2923
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>             Fix For: 1.2.0
>
>         Attachments: DRILL-2923.1.patch.txt
>
>
> I recently discovered that the test TestValueVector.java only passes if assertions are
enabled (-ea to the JVM). This means that there are conditions which will fail in the wild,
because production users don't run with assertions enabled. Someone needs to do a test run
of mvn install with the -ea removed from the surefire command line and make sure that everything
passes, and if not, we should fix them. We should also find a way to do this periodically,
as part of CI, or as part of our regular test suites.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message