Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Sat, 25 Apr 2015 14:54:38 +0000 (UTC)
From: "Deneche A. Hakim (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12823988.1429972218000.27845.1429973678356@Atlassian.JIRA>
In-Reply-To: <JIRA.12823988.1429972218000@Atlassian.JIRA>
References: <JIRA.12823988.1429972218000@Atlassian.JIRA>
 <JIRA.12823988.1429972218623@arcas>
Subject: [jira] [Commented] (DRILL-2878)
 FragmentExecutor.closeOutResources() is not called if an exception happens
 in the Foreman before the fragment executor starts running
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DRILL-2878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512522#comment-14512522 ] 

Deneche A. Hakim commented on DRILL-2878:
-----------------------------------------

A similar problem happens if a non root fragment fails before the root fragment starts running (it's still waiting for data). The Foreman will cancel all fragments, but the root fragment will never get to call it's closeOutResources() method. 

You can easily reproduce this problem with the following unit test
{noformat}
org.apache.drill.exec.server.TestDrillbitResilience#failsDuringExecution
{noformat}

> FragmentExecutor.closeOutResources() is not called if an exception happens in the Foreman before the fragment executor starts running
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-2878
>                 URL: https://issues.apache.org/jira/browse/DRILL-2878
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Deneche A. Hakim
>            Assignee: Chris Westin
>
> When the Foreman sets up the root FragmentExecutor and it needs to wait for data from the remote fragments, the fragment manager is recorded in the work bus and the root fragment executor is not run immediately.
> If an exception happens in the Foreman while setting up the remote fragments, the Foreman cancels all fragments and returns a FAILED message to the client.
> Because the root fragment executor was not run it will never call it's closeOutResources() method and it's fragment context will never be closed.
> You can easily reproduce this by running the following unit test:
> {noformat}
> org.apache.drill.exec.server.TestDrillbitResilience#failsWhenSendingFragments
> {noformat}
> although the test passes successfully because Drill does report the correct failure to the client, the memory leak is not detected and will show up after the test finishes


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)