Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E86C71761A for ; Thu, 23 Apr 2015 18:46:38 +0000 (UTC) Received: (qmail 72593 invoked by uid 500); 23 Apr 2015 18:46:38 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 72558 invoked by uid 500); 23 Apr 2015 18:46:38 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 72510 invoked by uid 99); 23 Apr 2015 18:46:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Apr 2015 18:46:38 +0000 Date: Thu, 23 Apr 2015 18:46:38 +0000 (UTC) From: "Venki Korukanti (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DRILL-2858) Refactor hash expression construction in InsertLocalExchangeVisitor and PrelUtil into one place MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venki Korukanti updated DRILL-2858: ----------------------------------- Component/s: Execution - Relational Operators > Refactor hash expression construction in InsertLocalExchangeVisitor and PrelUtil into one place > ----------------------------------------------------------------------------------------------- > > Key: DRILL-2858 > URL: https://issues.apache.org/jira/browse/DRILL-2858 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Relational Operators > Affects Versions: 0.8.0 > Reporter: Venki Korukanti > Assignee: Venki Korukanti > Fix For: 0.9.0 > > > Currently there are two place where we construct the hash expression based on the partition fields: > 1. InsertLocalExchangeVistor (generates RexExpr type) > 2. PRelUtil.getHashExpression (generate LogicalExpression type) > Having this logic in two places makes them prone to errors and they can easily go out of sync causing hard to debug verification failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)