Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAF7017C2C for ; Thu, 9 Apr 2015 02:08:13 +0000 (UTC) Received: (qmail 69336 invoked by uid 500); 9 Apr 2015 02:08:13 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 69309 invoked by uid 500); 9 Apr 2015 02:08:13 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 69294 invoked by uid 99); 9 Apr 2015 02:08:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2015 02:08:13 +0000 Date: Thu, 9 Apr 2015 02:08:13 +0000 (UTC) From: "Hanifi Gunes (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-2719) Behavior of ValueVector#getBuffers(clear) is inconsistent across VV types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486573#comment-14486573 ] Hanifi Gunes commented on DRILL-2719: ------------------------------------- Should not cause any hard conflicts. Thanks for letting me know. > Behavior of ValueVector#getBuffers(clear) is inconsistent across VV types > ------------------------------------------------------------------------- > > Key: DRILL-2719 > URL: https://issues.apache.org/jira/browse/DRILL-2719 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Data Types > Affects Versions: 0.8.0 > Reporter: Hanifi Gunes > Assignee: Hanifi Gunes > Fix For: 0.9.0 > > > The major cause of inconsistency here is that reference count does not change upon a call to BaseDataVV#getBuffers. However, it does change when the method is invoked on a composite vector type. See for instance VariableLengthVV[1] or a NullableVV[2]. > The proposal is to make this behavior consistent first and later we can consider separating out the logic that clears a vector from the logic that returns underlying buffers. > [1]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java#L151 > [2]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java#L82 -- This message was sent by Atlassian JIRA (v6.3.4#6332)