drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deneche A. Hakim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-2894) FixedValueVectors shouldn't set it's data buffer to null when it fails to allocate it
Date Wed, 29 Apr 2015 01:13:06 GMT
Deneche A. Hakim created DRILL-2894:
---------------------------------------

             Summary: FixedValueVectors shouldn't set it's data buffer to null when it fails
to allocate it
                 Key: DRILL-2894
                 URL: https://issues.apache.org/jira/browse/DRILL-2894
             Project: Apache Drill
          Issue Type: Bug
          Components: Execution - Data Types
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim
             Fix For: 1.0.0


this is related to DRILL-2893

In _FixedValueVectors.java_ the following allocation methods will set the _data_ field to
null if they fail to allocate properly:
- _allocateNewSafe()_
- _allocateNew(int valueCount)_
- _reAlloc()_

This will cause 2 problems:
1. both _allocateNew(int valueCount)_ and _reAlloc()_ will throw a _NullPointerException_
when it fails to allocate. This is somewhat properly taken care of by the calling code
2. when the operators are cleaning up, calling _clear()_ on a vector with a null data buffer
will throw a _NullPointerException_ preventing the cleanup from finishing up properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message