drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2879) Drill extended json's support $oid
Date Wed, 29 Apr 2015 16:06:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519629#comment-14519629
] 

Jacques Nadeau commented on DRILL-2879:
---------------------------------------

Can you please make this JIRA more specific.  I think some of the things you are proposing
in this patch need to be discussed further.  

Drill currently supports a subset/superset of mongo's extended type definition.  We've added
some new types as well as support parsing some of Mongo's specification.  All of the types
Drill supports are symmetric and adequate for Drill's data model.  If you want to enhance
Drill to support additional variations of certain types (e.g. timestamp with a integer, binary
with a binary type), I'm all for that but your current patch simply changes the handling to
support a different subset of encodings.  Can you please update your patch so that Drill's
default behavior stays the same and you are simply adding new decoding support.

Another question that comes up when reviewing this is whether we should non-symmetric extended
types.  For example: if we take in an oid, Drill has no internal representation of that so
we have to come up with one (you're using VarChar right now but I'd be inclined to use VarBinary).
 In those cases, when Drill exports back to JSON, that type information will be lost.  I'm
not sure this is better than the current handling (not dropping the $ structure in the case
that Drill can't return that data symmetrically on JSON export).

> Drill extended json's support $oid
> ----------------------------------
>
>                 Key: DRILL-2879
>                 URL: https://issues.apache.org/jira/browse/DRILL-2879
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - JSON
>            Reporter: Bhallamudi Venkata Siva Kamesh
>            Assignee: Steven Phillips
>         Attachments: extended.json, extendedjson.patch
>
>
> Enhancing JSON reader to parse  $oid (from mongo). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message