Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2D1210908 for ; Mon, 16 Mar 2015 17:36:38 +0000 (UTC) Received: (qmail 24785 invoked by uid 500); 16 Mar 2015 17:36:38 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 24754 invoked by uid 500); 16 Mar 2015 17:36:38 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 24742 invoked by uid 99); 16 Mar 2015 17:36:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 17:36:38 +0000 Date: Mon, 16 Mar 2015 17:36:38 +0000 (UTC) From: "Mehant Baid (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-2448) Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit casting subsumes it MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363559#comment-14363559 ] Mehant Baid commented on DRILL-2448: ------------------------------------ +1 > Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit casting subsumes it > -------------------------------------------------------------------------------------------------------------- > > Key: DRILL-2448 > URL: https://issues.apache.org/jira/browse/DRILL-2448 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Data Types > Affects Versions: 0.7.0 > Reporter: Jason Altekruse > Assignee: Jason Altekruse > Priority: Critical > Fix For: 0.8.0 > > Attachments: DRILL-2448-varchar-varbinary-implicit-cast.patch > > > Function resolution included a small condition to allow varchar and varbinary functions to be resolved for either incoming type. While it is valid to implicitly cast between these two, this early workaround creates a technically invalid expression tree that happens to work with the current code generation system. This however does create an issue for the interpreted expression evaluator. Removing the code simply causes an implicit cast to be added during materialization, this works for both generated code expression evaluation as well as the interpreter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)