Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D943F179B3 for ; Fri, 6 Mar 2015 01:44:39 +0000 (UTC) Received: (qmail 93959 invoked by uid 500); 6 Mar 2015 01:44:39 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 93898 invoked by uid 500); 6 Mar 2015 01:44:39 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 93863 invoked by uid 99); 6 Mar 2015 01:44:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 01:44:39 +0000 Date: Fri, 6 Mar 2015 01:44:38 +0000 (UTC) From: "Jason Altekruse (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (DRILL-2395) Improve interpreted expression evaluation to only call the setup method once per batch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse reassigned DRILL-2395: -------------------------------------- Assignee: Jason Altekruse (was: Daniel Barclay (Drill)) > Improve interpreted expression evaluation to only call the setup method once per batch > -------------------------------------------------------------------------------------- > > Key: DRILL-2395 > URL: https://issues.apache.org/jira/browse/DRILL-2395 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill > Reporter: Jason Altekruse > Assignee: Jason Altekruse > Priority: Minor > > This enhancement request came out of the review for a patch for DRILL-2060. Copied below is the discussion from there: > Jinfeng: > Do you have a plan to move setup() call into places such that setup() will be called once for each VectorAccessible input? > In the code compile + evaluation model, doSetup() will be called per batch, in stead of per row. > Jason: > I have started working on a fix for this. Its a little complicated with setting constant inputs before the setup method is called. I'm trying to figure out the best way to share code with the rest of the input passing used in the EvalVisitor. Would you be okay with this being opened as an enhancement request to be merged a little later? Considering the current use of the interpreter this won't have an impact on any actual queries today. -- This message was sent by Atlassian JIRA (v6.3.4#6332)