drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristine Hahn (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (DRILL-2477) duplicate TIMESTAMPTZ in TypeCastRules.java
Date Mon, 16 Mar 2015 20:46:41 GMT

     [ https://issues.apache.org/jira/browse/DRILL-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristine Hahn closed DRILL-2477.
--------------------------------
    Resolution: Invalid

I see now this isn't a single case of duplication, so it must be intentional.

> duplicate TIMESTAMPTZ in TypeCastRules.java
> -------------------------------------------
>
>                 Key: DRILL-2477
>                 URL: https://issues.apache.org/jira/browse/DRILL-2477
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Kristine Hahn
>            Priority: Trivial
>
> Looks like an unintentional duplication on lines 629 and 642 you'd want to know about
(even though TIMESTAMPTZ isn't supported):
> 612    /** FIXED16CHAR cast able from **/
> 613    rule = new HashSet<MinorType>();
> 614    rule.add(MinorType.TINYINT);
> 615    rule.add(MinorType.SMALLINT);
> 616    rule.add(MinorType.INT);
> 617    rule.add(MinorType.BIGINT);
> 618    rule.add(MinorType.UINT1);
> 619    rule.add(MinorType.UINT2);
> 620    rule.add(MinorType.UINT4);
> 621    rule.add(MinorType.UINT8);
> 622    rule.add(MinorType.DECIMAL9);
> 623    rule.add(MinorType.DECIMAL18);
> 624    rule.add(MinorType.DECIMAL28SPARSE);
> 625    rule.add(MinorType.DECIMAL28DENSE);
> 626   rule.add(MinorType.DECIMAL38SPARSE);
> 627    rule.add(MinorType.DECIMAL38DENSE);
> 628    rule.add(MinorType.MONEY);
> 629    rule.add(MinorType.TIMESTAMPTZ);
> 630    rule.add(MinorType.FLOAT4);
> 631    rule.add(MinorType.FLOAT8);
> 632    rule.add(MinorType.BIT);
> 633    rule.add(MinorType.FIXEDCHAR);
> 634    rule.add(MinorType.FIXED16CHAR);
> 635    rule.add(MinorType.VARCHAR);
> 636    rule.add(MinorType.VAR16CHAR);
> 637    rule.add(MinorType.VARBINARY);
> 638    rule.add(MinorType.FIXEDBINARY);
> 639    rule.add(MinorType.DATE);
> 640    rule.add(MinorType.TIME);
> 641    rule.add(MinorType.TIMESTAMP);
> 642    rule.add(MinorType.TIMESTAMPTZ);
> 643    rule.add(MinorType.INTERVAL);
> 644    rule.add(MinorType.INTERVALYEAR);
> 645    rule.add(MinorType.INTERVALDAY);
> 646    rules.put(MinorType.FIXED16CHAR, rule);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message