drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mehant Baid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2448) Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit casting subsumes it
Date Mon, 16 Mar 2015 17:36:38 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363559#comment-14363559
] 

Mehant Baid commented on DRILL-2448:
------------------------------------

+1

> Remove outdated code to ignore type resolution with varchar vs varbinary now that implicit
casting subsumes it
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-2448
>                 URL: https://issues.apache.org/jira/browse/DRILL-2448
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Data Types
>    Affects Versions: 0.7.0
>            Reporter: Jason Altekruse
>            Assignee: Jason Altekruse
>            Priority: Critical
>             Fix For: 0.8.0
>
>         Attachments: DRILL-2448-varchar-varbinary-implicit-cast.patch
>
>
> Function resolution included a small condition to allow varchar and varbinary functions
to be resolved for either incoming type. While it is valid to implicitly cast between these
two, this early workaround creates a technically invalid expression tree that happens to work
with the current code generation system. This however does create an issue for the interpreted
expression evaluator. Removing the code simply causes an implicit cast to be added during
materialization, this works for both generated code expression evaluation as well as the interpreter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message