Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 18 Feb 2015 22:43:12 +0000 (UTC)
From: "Jinfeng Ni (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12776012.1424299379000.80897.1424299392165@Atlassian.JIRA>
In-Reply-To: <JIRA.12776012.1424299379000@Atlassian.JIRA>
References: <JIRA.12776012.1424299379000@Atlassian.JIRA>
 <JIRA.12776012.1424299379357@arcas>
Subject: [jira] [Created] (DRILL-2269) Provide default implementation for
 getting cost of evaluating an expression in base class of
 LogicalExpression, in stead of throw Exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Jinfeng Ni created DRILL-2269:
---------------------------------

             Summary: Provide default implementation for getting cost of evaluating an expression in base class of LogicalExpression, in stead of throw Exception 
                 Key: DRILL-2269
                 URL: https://issues.apache.org/jira/browse/DRILL-2269
             Project: Apache Drill
          Issue Type: Bug
            Reporter: Jinfeng Ni


Today, the abstract class of LogicalExpression will throw Exception for two methods related to estimate the cost of evaluating an expression, in the hope that sub classes will override those two methods. However, if someone forgets to override, compiler and mvn build process will still be successful, yet will hit Exception in execution-time, complaining the sub class does not implement these methods.  As Drill's adding more sub classes of LogicalExpression to the code base, it's more likely for someone to forget to override those two methods, making it error-prone to just throw Exception in the base class.

In stead, we should provide a default implementation for those two methods in the base class. Certain sub classes will override to change the behavior. 
  

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)