drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2321) FlattenRecordBatch should transfer vectors honoring output field reference.
Date Fri, 27 Feb 2015 01:58:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339585#comment-14339585
] 

Jason Altekruse commented on DRILL-2321:
----------------------------------------

+1 lgtm

> FlattenRecordBatch should transfer vectors honoring output field reference.
> ---------------------------------------------------------------------------
>
>                 Key: DRILL-2321
>                 URL: https://issues.apache.org/jira/browse/DRILL-2321
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Hanifi Gunes
>            Assignee: Jason Altekruse
>             Fix For: 0.9.0
>
>         Attachments: DRILL-2321.1.patch.txt
>
>
> Current implementation of FlattenRecordBatch does not create transfer pairs with the
target vector named with the desired field reference. This seems working fine with repeated
types as the upstream project or ArrayPathSegment makes the renaming implicitly. Overall relying
on upstream makes the code fragile. Also, DRILL-2150 requires this patch as it alters the
way repeated vectors are modeled. This patch proposes to implement a less fragile transfer
pair handling via explicit naming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message