drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Westin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DRILL-2245) Improve Drillbit resiliency
Date Wed, 25 Feb 2015 21:46:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337223#comment-14337223
] 

Chris Westin edited comment on DRILL-2245 at 2/25/15 9:46 PM:
--------------------------------------------------------------

Split the single patch into two for review purposes. The core patch includes all the work
to improve resiliency, along with cleanup of those files. The hygiene patch is just files
that were cleaned up as they were read during the process. To be safe, apply both or neither,
just in case my visual inspection during the splitting process missed any minor dependencies
such as removal of unused function arguments, or function renaming. These two patches will
be uploaded to Review Board independently.

Here are the two reviews for core and hygiene, respectively:
https://reviews.apache.org/r/31435/
https://reviews.apache.org/r/31436/



was (Author: cwestin):
Split the single patch into two for review purposes. The core patch includes all the work
to improve resiliency, along with cleanup of those files. The hygiene patch is just files
that were cleaned up as they were read during the process. To be safe, apply both or neither,
just in case my visual inspection during the splitting process missed any minor dependencies
such as removal of unused function arguments, or function renaming. These two patches will
be uploaded to Review Board independently.

> Improve Drillbit resiliency
> ---------------------------
>
>                 Key: DRILL-2245
>                 URL: https://issues.apache.org/jira/browse/DRILL-2245
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>         Attachments: DRILL-2245.1.patch.txt, DRILL-2245.2.patch.txt, DRILL-2245.3-core.patch.txt,
DRILL-2245.3-hygiene.patch.txt
>
>
> There are paths through WorkManager and Foreman that will allow a Drillbit to get wedged
if there are failures. This can happen because events delivered via other threads will get
stuck if Foreman throws an exception before it is accepting external events.
> This is a call to do some general cleanup here and make drillbits more robust so that
they don't hang when there are query failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message