drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2143) Remove RecordBatch from setup method of DrillFunc interface
Date Fri, 06 Feb 2015 21:21:35 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309941#comment-14309941
] 

Jason Altekruse commented on DRILL-2143:
----------------------------------------

I'm breaking this up into two separate reviews. There are 6 pages on reviewboard for just
intellij refactoring as well as find/replace in freemarker templates to get the interface
changed. I will post these to the original review, and open a new one for the addition of
the new QueryDateTimeInfo injectable type as well as the changes for making the expression
interpreter work with the new interface.

> Remove RecordBatch from setup method of DrillFunc interface
> -----------------------------------------------------------
>
>                 Key: DRILL-2143
>                 URL: https://issues.apache.org/jira/browse/DRILL-2143
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>            Reporter: Jason Altekruse
>            Assignee: Jason Altekruse
>         Attachments: DRILL-2143-remove-record-batch-from-udfs.patch
>
>
> Drill UDFs currently are exposed to too much system state by receiving a reference to
a RecordBatch in their setup method. This is not necessary as all of the schema change triggered
operator functionality is handled outside of UDFs (the UDFS themselves are actually required
to define a specific type they take as input, except in the case of complex types (maps and
lists)). The only remaining artifact left from this interface is the date/time functions that
ask for the query start time or current timezone. This can be provided to functions using
a new injectable type, as DrillBufs are provided to functions currently. For more info read
here: http://mail-archives.apache.org/mod_mbox/drill-dev/201501.mbox/%3CCAMpYv7AC_-9u4iRZ+5fxoenzBOJCTovJronn0qri4BQZf535Qw@mail.gmail.com%3E




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message