drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinfeng Ni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2054) Support `||` as "concat operator" for varchar inputs
Date Tue, 03 Feb 2015 23:05:34 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304262#comment-14304262
] 

Jinfeng Ni commented on DRILL-2054:
-----------------------------------

Minor comments:

1. For Junit test, add combination of   c1 || c2,   cast(c1 as varchar(30)) || cast(c2 as
varchar(30)), where c1/c2 is "any" type when it goes through Calcite/optiq, but actually a
varchar column in a schemaless-table.  These two cases covers cases of "any" || "any",  varchar
|| varchar. 

The test you have only tests  the case of any || varchar.




> Support `||` as "concat operator" for varchar inputs
> ----------------------------------------------------
>
>                 Key: DRILL-2054
>                 URL: https://issues.apache.org/jira/browse/DRILL-2054
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Sean Hsuan-Yi Chu
>            Assignee: Jinfeng Ni
>             Fix For: Future
>
>         Attachments: DRILL-2054.1.patch, DRILL-2054.2.patch, DRILL-2054ForOptiq.1.patch
>
>
> For example, the query:
> select n_nationkey || ' + ' || n_name || ' = ' as CONCAT, n_nationkey, ' + ' as PLUS,
n_name from cp.`tpch/nation.parquet`
> should print out 
> CONCAT	n_nationkey	PLUS	n_name
> 0 + ALGERIA = 	0	 + 	ALGERIA
> 1 + ARGENTINA = 	1	 + 	ARGENTINA
> 2 + BRAZIL = 	2	 + 	BRAZIL
> 3 + CANADA = 	3	 + 	CANADA
> ... ... ... (rows/records are omitted due to space limitation)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message