Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29E46CFC1 for ; Fri, 9 Jan 2015 16:25:34 +0000 (UTC) Received: (qmail 27523 invoked by uid 500); 9 Jan 2015 16:25:35 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 27495 invoked by uid 500); 9 Jan 2015 16:25:35 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 27485 invoked by uid 99); 9 Jan 2015 16:25:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jan 2015 16:25:35 +0000 Date: Fri, 9 Jan 2015 16:25:35 +0000 (UTC) From: "Jacques Nadeau (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-1888) Memory leak for aggregation with HAVING clause MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271478#comment-14271478 ] Jacques Nadeau commented on DRILL-1888: --------------------------------------- We really need to stop relying on external calls to cleanup(). An operator should clean all of its owned memory before returning NONE. > Memory leak for aggregation with HAVING clause > ---------------------------------------------- > > Key: DRILL-1888 > URL: https://issues.apache.org/jira/browse/DRILL-1888 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Operators > Affects Versions: 0.6.0 > Reporter: Victoria Markman > Assignee: Aman Sinha > Fix For: 0.8.0 > > > Use TPC-DS scema and run query below: > {code} > SELECT > wr_returning_customer_sk, > wr_returned_date_sk, > sum(wr_return_amt)/sum(wr_return_quantity) as avg_return_amt > FROM web_returns > WHERE ( > wr_item_sk in ( > SELECT > ws_item_sk > FROM web_sales > WHERE ws_sales_price < 50 or ws_ext_sales_price < 1000) > or wr_item_sk in (1, 2, 3, 4, 5, 6, 7, 8, 9, 10) ) > and wr_reason_sk in (10) > GROUP BY > wr_returning_customer_sk, > wr_returned_date_sk > HAVING sum(wr_return_amt)/sum(wr_return_quantity) >= 50.0; > {code} > > From drillbit.log > {code} > Total 1 allocation(s) of byte size(s): 4096, at stack location: > org.apache.drill.exec.memory.TopLevelAllocator$ChildAllocator.buffer(TopLevelAllocator.java:212) > org.apache.drill.exec.vector.UInt1Vector.allocateNewSafe(UInt1Vector.java:137) > org.apache.drill.exec.vector.UInt1Vector.allocateNew(UInt1Vector.java:123) > org.apache.drill.exec.vector.NullableIntVector.allocateNew(NullableIntVector.java:163) > org.apache.drill.exec.physical.impl.aggregate.HashAggBatch.buildSchema(HashAggBatch.java:101) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:130) > org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:99) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:89) > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:51) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:142) > org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:99) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:89) > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:51) > org.apache.drill.exec.physical.impl.svremover.RemovingRecordBatch.innerNext(RemovingRecordBatch.java:96) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:142) > org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:99) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:89) > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:51) > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext(ProjectRecordBatch.java:132) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:142) > org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:99) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:89) > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:51) > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext(ProjectRecordBatch.java:132) > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:142) > org.apache.drill.exec.physical.impl.validate.IteratorValidatorBatchIterator.next(IteratorValidatorBatchIterator.java:118) > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:67) > org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext(ScreenCreator.java:97) > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:57) > org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:114) > org.apache.drill.exec.work.WorkManager$RunnableWrapper.run(WorkManager.java:254) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)