Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDBA710E5C for ; Sun, 4 Jan 2015 21:29:38 +0000 (UTC) Received: (qmail 1715 invoked by uid 500); 4 Jan 2015 21:29:39 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 1684 invoked by uid 500); 4 Jan 2015 21:29:39 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 1673 invoked by uid 99); 4 Jan 2015 21:29:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Jan 2015 21:29:39 +0000 Date: Sun, 4 Jan 2015 21:29:39 +0000 (UTC) From: "Jacques Nadeau (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (DRILL-340) Ensure methods intended to create new copies of plan nodes are actually creating copies of all nested objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-340. ---------------------------------- Resolution: Won't Fix > Ensure methods intended to create new copies of plan nodes are actually creating copies of all nested objects > ------------------------------------------------------------------------------------------------------------- > > Key: DRILL-340 > URL: https://issues.apache.org/jira/browse/DRILL-340 > Project: Apache Drill > Issue Type: Bug > Reporter: Jason Altekruse > Fix For: Future > > > Methods such as getNewWithChildren declared in the PhysicalOperator interface are designed to create copies of plan nodes. These copy operations should not reference any part of the old nodes, thus child objects should be deep copied, including lists of objects. For more information on the desired functionality see here: http://en.wikipedia.org/wiki/Clone_(Java_method) > Existing implementations should be checked for correctness. We may want to create this functionality for logical operators as well, but I do not believe that we should need to do manipulations on logical plans that would require it. Our optimization of plans will happen in the logical to physical plan transformation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)